Add opaque host memory allocation IPC test #306
+134
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: NEO-15836 Signed-off-by: Eric Mortensen <[email protected]>
aravindksg
reviewed
Oct 8, 2025
| lzt::destroy_context(context); | ||
| } | ||
|
|
||
| static void run_ipc_host_mem_access_test_opaque(size_t size, |
There was a problem hiding this comment.
do we need new function for host mem? lot of code is duplicated right? can we have another arg to original function such as run_ipc_mem_access_test_opaque(..., bool inDeviceMem) that dictates whether you call allocate_host_memory() or allocate_device_memory?
| GivenL0MemoryAllocatedInChildProcessWhenUsingL0IPCThenParentProcessReadsMemoryCorrectly) { | ||
| run_ipc_mem_access_test_opaque(TEST_DEVICE_ACCESS, 4096, false, | ||
| ZE_IPC_MEMORY_FLAG_BIAS_UNCACHED, false); | ||
| run_ipc_dev_mem_access_test_opaque(TEST_DEVICE_ACCESS, 4096, false, |
There was a problem hiding this comment.
it might be good to state the memory placement in Test name above, i.e something like "GivenL0MemoryAllocatedInChildInDeviceMem*" so we can easily identify in GTA runs what kind passes/fails. thoughts @nrspruit ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new tests for allocating opaque host memory for IPC.
Related-To: NEO-15836